Lesson 6: Creating a collectible

As of godot 4 beta 4 there is a random pick from array function.
At 15m55s, line 42 and 43 can now be:

	var random_platform = available_platforms.pick_random()
	var new_platform = random_platform.instantiate()

This could be very nice tutorial, but it’s way too fast. It is impossible to follow you in this course, because you are pasting things, so it’s very frustraiting to stop or rewind it all the times to catch you up. In this lesson you forgot to mention about line of code with collect_sound varible (9 minute).

Why do we set the label text on every frame rather than just when the score changes?

And would it not be more performant to create the available_platforms array once rather than every spawn call?

A thing that could be done a little bit better is to put a clamp on the collectible_pitch variable, as, in the case of the game spawning multiple platforms with “row” collectibles, the sound becomes jarring.

After the collectible_pitch += 0.1 line, add:

collectible_pitch = clamp(collectible_pitch, 1.0, 2.0)

For some reason when I run the game my animation for picking up the collectible runs in a loop over and over again and the last collectible becomes hidden behind the platform but I am still able to collect it. Here is my code for the collectible:

extends Area2D

@export var value = 10

@onready var game = $"/root/World"
@onready var sprite = $AnimatedSprite2D

# Called when the node enters the scene tree for the first time.
func _ready():
	self.body_entered.connect(_on_body_entered)
	
func _on_body_entered(body):
	if body.is_in_group("player"):
		game.add_score(value)
		sprite.play("collected")
		sprite.animation_finished.connect(_on_animation_finished)
		
func _on_animation_finished():
	queue_free()
	
func _process(delta):
	pass

I have gone back and looked at the code in the lecture to what I have but I didn’t notice anything different. I tried deleting the animation and recreating it but that didn’t seem to do anything. I feel like I missed a step in the code that removes it from the scene.

Never mind. I forgot to disable looping.

cool

Collision is not triggering for me on Godot Engine v4.2.2.stable.flathub [15073afe3]

Player - CharacterBody2D is in a group named player and is on Collision Layer 2. Everything looks setup correctly as everything up till this point works as the guide states.

Collectible - Area2D has AnimatedSprite2D & CollisionShape2D (including looping off in the animation frames for the collected animation). It is also on Collision Layer 2.

I put some print statements to help identify in the Output where something isn’t working. On play, the first print statement in func _ready() prints collectible ready in the output stream. However, the second print statement in func _on_body_entered(body) never prints body entered. So, this leads me to believe that the self.body_entered.connect(_on_body_entered) statement never triggers.

I first thought it a problem with body_entered but the documents state it can be a PhysicsBody2D which CharacterBody2D is inherited by. I also, thought that this might only trigger on the first frame since it is in the _ready() function, but this seem not to be the case either. Or if it is, I don’t know where it should go.

NOTE: My game variable points to World_Node2D instead of World, because I named it that to help me with my learning.

@export var value = 10

@onready var game = $"/root/World_Node2D"
@onready var sprite = $AnimatedSprite2D

# Called when the node enters the scene tree for the first time.
func _ready():
    print("collectible ready")
    self.body_entered.connect(_on_body_entered)
    
func _on_body_entered(body):
    print("body entered")
    if body.is_in_group("player"):
        game.add_score(value)
        sprite.play("collected")
        sprite.animation_finished.connect(_on_animation_finished)
        
func _on_animation_finished():
    queue_free()
# Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
    pass